PMD Results

The following document contains the results of PMD 3.7.

Files

de/aixcept/flex2/annotations/apt/ActionScriptAnnotationProcessor.java

ViolationLine
Avoid really long classes.52 - 1119
The class 'ActionScriptAnnotationProcessor' has a Cyclomatic Complexity of 5 (Highest = 22).52 - 1119
Avoid using implementation types like 'HashMap'; use the interface instead62
Avoid excessively long variable names like ACTION_SCRIPT_TYPE_MAP62
The String literal "int" appears 7 times in this file; the first occurrence is on line 6868
The String literal "Number" appears 7 times in this file; the first occurrence is on line 7575
The String literal "String" appears 5 times in this file; the first occurrence is on line 8787
The String literal "mx.collections.ArrayCollection" appears 5 times in this file; the first occurrence is on line 9393
The String literal "Date" appears 5 times in this file; the first occurrence is on line 100100
Avoid excessively long variable names like BUSINESS_DELEGATES113
Avoid excessively long variable names like COMMAND_WITH_DELEGATE115
Avoid excessively long variable names like COMMAND_WITHOUT_DELEGATE116
Private field 'environment' could be made final; it is only initialized in the declaration or constructor.126
Found non-transient, non-static member. Please mark as transient or provide accessors.126
Private field 'actionScriptDeclaration' could be made final; it is only initialized in the declaration or constructor.127
Found non-transient, non-static member. Please mark as transient or provide accessors.127
Avoid excessively long variable names like actionScriptDeclaration127
Private field 'actionScriptPropertyDeclaration' could be made final; it is only initialized in the declaration or constructor.128
Found non-transient, non-static member. Please mark as transient or provide accessors.128
Avoid excessively long variable names like actionScriptPropertyDeclaration128
Private field 'actionScriptRegistryInfo' could be made final; it is only initialized in the declaration or constructor.129
Found non-transient, non-static member. Please mark as transient or provide accessors.129
Avoid excessively long variable names like actionScriptRegistryInfo129
Private field 'actionScriptInfos' could be made final; it is only initialized in the declaration or constructor.130
Found non-transient, non-static member. Please mark as transient or provide accessors.130
Perhaps 'cairngormTags' could be replaced by a local variable.131
Private field 'cairngormTags' could be made final; it is only initialized in the declaration or constructor.131
Found non-transient, non-static member. Please mark as transient or provide accessors.131
Private field 'eventTags' could be made final; it is only initialized in the declaration or constructor.133
Found non-transient, non-static member. Please mark as transient or provide accessors.133
Private field 'commandWithDelegateTags' could be made final; it is only initialized in the declaration or constructor.134
Found non-transient, non-static member. Please mark as transient or provide accessors.134
Avoid excessively long variable names like commandWithDelegateTags134
Private field 'commandTags' could be made final; it is only initialized in the declaration or constructor.135
Found non-transient, non-static member. Please mark as transient or provide accessors.135
Avoid excessively long variable names like actionScriptDeclarations149
Local variable could be declared final149
Avoid excessively long variable names like actionScriptPropertyDeclarations150
Local variable could be declared final150
Avoid really long methods.177 - 293
The method 'processCairngormDeclarations' has a Cyclomatic Complexity of 17.177 - 293
Avoid excessively long variable names like cairngormDeclaration178
Local variable could be declared final178
Avoid excessively long variable names like cairngormDeclarations179
Local variable could be declared final179
Local variable could be declared final184
Local variable could be declared final185
Local variable could be declared final188
Avoid instantiating new objects inside loops188
String.indexOf(char) is faster than String.indexOf(String)191
String.indexOf(char) is faster than String.indexOf(String)192
Local variable could be declared final198
Local variable could be declared final212
Local variable could be declared final214
Local variable could be declared final217
Avoid variables with short names like bd218
Local variable could be declared final218
Avoid instantiating new objects inside loops218
The String literal "name" appears 10 times in this file; the first occurrence is on line 219219
Local variable could be declared final229
Avoid excessively long variable names like commandWithDelegates231
Local variable could be declared final231
Local variable could be declared final234
Local variable could be declared final235
Avoid instantiating new objects inside loops235
Deeply nested if..then statements are hard to read238 - 240
Position literals first in String comparisons238
Deeply nested if..then statements are hard to read243 - 245
Position literals first in String comparisons243
Avoid excessively long variable names like commandWithoutDelegates260
Local variable could be declared final260
Local variable could be declared final263
Local variable could be declared final264
Avoid instantiating new objects inside loops264
Deeply nested if..then statements are hard to read267 - 269
Position literals first in String comparisons267
Parameter 'info' is not assigned and could be declared final295
Parameter 'event' is not assigned and could be declared final295
Local variable could be declared final296
When doing a String.toLowerCase()/toUpperCase() call, use a Locale300
The method 'processAttributesDeclarations' has a Cyclomatic Complexity of 10.305 - 384
Avoid excessively long variable names like attributesDeclarations305
Parameter 'attributesDeclarations' is not assigned and could be declared final305
Local variable could be declared final309
Local variable could be declared final310
Local variable could be declared final311
Local variable could be declared final314
Avoid instantiating new objects inside loops314
Local variable could be declared final319
Avoid variables with short names like c328
Local variable could be declared final328
Local variable could be declared final329
Avoid variables with short names like f330
Local variable could be declared final330
Avoid variables with short names like o332
Local variable could be declared final332
The String literal "type" appears 8 times in this file; the first occurrence is on line 348348
String.indexOf(char) is faster than String.indexOf(String)353
String.indexOf(char) is faster than String.indexOf(String)360
Avoid if (x != y) ..; else ..;370 - 379
Avoid using if...else statements without curly braces371
Avoid instantiating new objects inside loops374
Parameter 'declarations' is not assigned and could be declared final386
Local variable could be declared final390
Local variable could be declared final391
Local variable could be declared final392
Local variable could be declared final395
Avoid instantiating new objects inside loops395
String.indexOf(char) is faster than String.indexOf(String)397
String.indexOf(char) is faster than String.indexOf(String)398
String.indexOf(char) is faster than String.indexOf(String)405
Local variable could be declared final426
Local variable could be declared final429
Local variable could be declared final435
Local variable could be declared final436
Local variable could be declared final437
Local variable could be declared final440
Avoid instantiating new objects inside loops440
Avoid empty catch blocks445 - 447
Avoid empty catch blocks453 - 455
String.indexOf(char) is faster than String.indexOf(String)460
Parameter 'property' is not assigned and could be declared final471
Parameter 'values' is not assigned and could be declared final471
Parameter 'info' is not assigned and could be declared final490
Local variable could be declared final493
Avoid assigments in operands497 - 510
Local variable could be declared final498
Avoid if (x != y) ..; else ..;501 - 509
Avoid using if statements without curly braces503 - 504
Avoid throwing raw exception types513
Parameter 'clazz' is not assigned and could be declared final517
Parameter 'actionScriptInfo' is not assigned and could be declared final517
Local variable could be declared final519
Local variable could be declared final520
Local variable could be declared final521
Local variable could be declared final525
Local variable could be declared final531
Local variable could be declared final534
Local variable could be declared final537
Avoid instantiating new objects inside loops537
Avoid throwing raw exception types550
Avoid using if statements without curly braces556 - 557
The String literal "outputDir" appears 10 times in this file; the first occurrence is on line 556556
Local variable could be declared final562
The String literal "UTF-8" appears 30 times in this file; the first occurrence is on line 565565
Local variable could be declared final570
Local variable could be declared final571
Local variable could be declared final575
Avoid instantiating new objects inside loops575
The String literal "info" appears 8 times in this file; the first occurrence is on line 576576
Avoid variables with short names like f578
Local variable could be declared final578
Avoid instantiating new objects inside loops578
Local variable could be declared final583
Avoid instantiating new objects inside loops583
Local variable could be declared final585
Avoid instantiating new objects inside loops585
Avoid throwing raw exception types598
Local variable could be declared final604
Local variable could be declared final612
Local variable could be declared final613
Local variable could be declared final617
Avoid instantiating new objects inside loops617
Avoid variables with short names like f620
Local variable could be declared final620
Avoid instantiating new objects inside loops620
Local variable could be declared final625
Avoid instantiating new objects inside loops625
Avoid throwing raw exception types637
Parameter 'info' is not assigned and could be declared final641
Local variable could be declared final643
Local variable could be declared final651
Local variable could be declared final652
Local variable could be declared final654
Avoid variables with short names like f663
Local variable could be declared final663
Local variable could be declared final668
Local variable could be declared final670
Avoid throwing raw exception types681
Local variable could be declared final689
Local variable could be declared final697
Local variable could be declared final698
Local variable could be declared final701
Avoid instantiating new objects inside loops701
Avoid variables with short names like f709
Local variable could be declared final709
Avoid instantiating new objects inside loops709
Local variable could be declared final714
Avoid instantiating new objects inside loops714
Local variable could be declared final716
Avoid instantiating new objects inside loops716
Avoid throwing raw exception types728
Local variable could be declared final735
Local variable could be declared final743
Local variable could be declared final744
Local variable could be declared final747
Avoid instantiating new objects inside loops747
Avoid variables with short names like f751
Local variable could be declared final751
Avoid instantiating new objects inside loops751
Local variable could be declared final762
Avoid instantiating new objects inside loops762
Local variable could be declared final764
Avoid instantiating new objects inside loops764
Avoid throwing raw exception types776
Local variable could be declared final780
Local variable could be declared final781
Local variable could be declared final784
Avoid instantiating new objects inside loops784
Avoid variables with short names like f792
Local variable could be declared final792
Avoid instantiating new objects inside loops792
Local variable could be declared final797
Avoid instantiating new objects inside loops797
Local variable could be declared final799
Avoid instantiating new objects inside loops799
Avoid throwing raw exception types811
Local variable could be declared final817
Local variable could be declared final825
Local variable could be declared final826
Local variable could be declared final828
Avoid variables with short names like f831
Local variable could be declared final831
Local variable could be declared final836
Local variable could be declared final837
Avoid throwing raw exception types847
Parameter 'type' is not assigned and could be declared final851
Parameter 'typeName' is not assigned and could be declared final855
A method should have only one exit point, and that should be the last statement in the method865
A method should have only one exit point, and that should be the last statement in the method871
The method 'evalSpecialActionScriptTypes' has a Cyclomatic Complexity of 10.881 - 932
Avoid reassigning parameters such as 'typeName'881
String.indexOf(char) is faster than String.indexOf(String)887
A method should have only one exit point, and that should be the last statement in the method895
Local variable could be declared final897
Avoid variables with short names like c899
Local variable could be declared final899
A method should have only one exit point, and that should be the last statement in the method902
A method should have only one exit point, and that should be the last statement in the method904
A method should have only one exit point, and that should be the last statement in the method906
A method should have only one exit point, and that should be the last statement in the method909
A method should have only one exit point, and that should be the last statement in the method915
A method should have only one exit point, and that should be the last statement in the method919
Avoid empty catch blocks923 - 925
The method 'convertValue' has a Cyclomatic Complexity of 22.934 - 1023
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Avoid reassigning parameters such as 'value'934
Parameter 'type' is not assigned and could be declared final934
Position literals first in String comparisons936
Position literals first in String comparisons938
Avoid variables with short names like c939
Local variable could be declared final939
Position literals first in String comparisons941
Avoid variables with short names like c942
Local variable could be declared final942
Position literals first in String comparisons944
Local variable could be declared final945
Local variable could be declared final946
Position literals first in String comparisons951
Local variable could be declared final952
Local variable could be declared final953
Position literals first in String comparisons958
Local variable could be declared final959
Position literals first in String comparisons961
Local variable could be declared final962
Local variable could be declared final967
Local variable could be declared final968
Avoid variables with short names like c978
Local variable could be declared final978
Local variable could be declared final981
Local variable could be declared final982
Avoid instantiating new objects inside loops982
Local variable could be declared final999
Local variable could be declared final1000
Parameter 'map' is not assigned and could be declared final1026
Local variable could be declared final1028
Avoid instantiating new objects inside loops1028
Avoid variables with short names like f1030
Local variable could be declared final1030
Avoid instantiating new objects inside loops1030
Parameter 'map' is not assigned and could be declared final1044
Parameter 'map' is not assigned and could be declared final1050
Parameter 'map' is not assigned and could be declared final1056
Parameter 'root' is not assigned and could be declared final1062
Parameter 'name' is not assigned and could be declared final1062
Local variable could be declared final1063
A method should have only one exit point, and that should be the last statement in the method1066
Parameter 'info' is not assigned and could be declared final1072
Parameter 'templateName' is not assigned and could be declared final1072
Parameter 'fileName' is not assigned and could be declared final1072
Parameter 'packageName' is not assigned and could be declared final1072
Parameter 'params' is not assigned and could be declared final1072
Local variable could be declared final1074
Local variable could be declared final1082
Local variable could be declared final1083
Local variable could be declared final1085
Avoid variables with short names like f1091
Local variable could be declared final1091
Local variable could be declared final1103
Local variable could be declared final1105
Avoid throwing raw exception types1116

de/aixcept/flex2/annotations/apt/ActionScriptAnnotationProcessorFactory.java

ViolationLine
Each class should declare at least one constructor34 - 82
Parameter 'env' is not assigned and could be declared final42
Parameter 'declarations' is not assigned and could be declared final42

de/aixcept/flex2/annotations/metadata/ActionScriptInfo.java

ViolationLine
Too many fields28 - 408
Each class should declare at least one constructor28 - 408
Private field 'attributes' could be made final; it is only initialized in the declaration or constructor.47
Found non-transient, non-static member. Please mark as transient or provide accessors.47
Private field 'skipAttributes' could be made final; it is only initialized in the declaration or constructor.48
Found non-transient, non-static member. Please mark as transient or provide accessors.48
Parameter 'property' is not assigned and could be declared final50
Avoid using if statements without curly braces51 - 52
Parameter 'include' is not assigned and could be declared final70
Parameter 'name' is not assigned and could be declared final80
Parameter 'manageable' is not assigned and could be declared final98
Parameter 'bindable' is not assigned and could be declared final116
Parameter 'remoteObject' is not assigned and could be declared final134
Parameter 'externalizable' is not assigned and could be declared final152
Parameter 'inherit' is not assigned and could be declared final170
Parameter 'createToString' is not assigned and could be declared final188
Parameter 'extendable' is not assigned and could be declared final207
Parameter 'comment' is not assigned and could be declared final225
Parameter 'packageName' is not assigned and could be declared final235
Parameter 'declaredType' is not assigned and could be declared final253
Parameter 'valueObject' is not assigned and could be declared final271
Parameter 'name' is not assigned and could be declared final284
Parameter 'superClass' is not assigned and could be declared final302
Avoid variables with short names like b313
Local variable could be declared final313
Local variable could be declared final340
Local variable could be declared final341
Avoid variables with short names like s346
Local variable could be declared final346
Parameter 'imports' is not assigned and could be declared final378
Parameter 'value' is not assigned and could be declared final382
Parameter 'constants' is not assigned and could be declared final400
Parameter 'typeValue' is not assigned and could be declared final404
Parameter 'field' is not assigned and could be declared final404

de/aixcept/flex2/annotations/metadata/ActionScriptPropertyInfo.java

ViolationLine
Each class should declare at least one constructor29 - 244
Parameter 'name' is not assigned and could be declared final58
Parameter 'bindable' is not assigned and could be declared final76
Parameter 'managed' is not assigned and could be declared final95
Parameter 'read' is not assigned and could be declared final114
Parameter 'write' is not assigned and could be declared final132
Parameter 'type' is not assigned and could be declared final150
Parameter 'javaType' is not assigned and could be declared final168
Parameter 'useDefaultValue' is not assigned and could be declared final186
Parameter 'defaultValue' is not assigned and could be declared final204
Parameter 'comment' is not assigned and could be declared final222
Parameter 'extendable' is not assigned and could be declared final241

de/aixcept/flex2/annotations/metadata/ActionScriptRegistryInfo.java

ViolationLine
Each class should declare at least one constructor32 - 101
Classes implementing Serializable should set a serialVersionUID32 - 101
Private field 'registry' could be made final; it is only initialized in the declaration or constructor.34
Found non-transient, non-static member. Please mark as transient or provide accessors.34
Private field 'imports' could be made final; it is only initialized in the declaration or constructor.35
Found non-transient, non-static member. Please mark as transient or provide accessors.35
Parameter 'pkgName' is not assigned and could be declared final53
Avoid if (x != y) ..; else ..;54 - 61
Avoid reassigning parameters such as 'clazz'70
Parameter 'name' is not assigned and could be declared final70
Local variable could be declared final72
String.indexOf(char) is faster than String.indexOf(String)72
Avoid empty catch blocks76 - 78
String.indexOf(char) is faster than String.indexOf(String)80

de/aixcept/flex2/annotations/metadata/BusinessDelegateInfo.java

ViolationLine
Each class should declare at least one constructor31 - 102
Parameter 'name' is not assigned and could be declared final53
Parameter 'packageName' is not assigned and could be declared final71
Parameter 'businessPackage' is not assigned and could be declared final89
Parameter 'include' is not assigned and could be declared final99

de/aixcept/flex2/annotations/metadata/CairngormInfo.java

ViolationLine
Too many fields36 - 454
Each class should declare at least one constructor36 - 454
Avoid excessively long variable names like commandsWithDelegate39
Avoid excessively long variable names like commandsWithoutDelegate40
Parameter 'name' is not assigned and could be declared final109
Parameter 'packageName' is not assigned and could be declared final127
Parameter 'include' is not assigned and could be declared final138
Parameter 'projectName' is not assigned and could be declared final156
Parameter 'namespace' is not assigned and could be declared final174
Parameter 'commandPackage' is not assigned and could be declared final192
Parameter 'controlPackage' is not assigned and could be declared final210
Parameter 'eventPackage' is not assigned and could be declared final228
Parameter 'businessPackage' is not assigned and could be declared final246
Parameter 'modelPackage' is not assigned and could be declared final264
Parameter 'viewPackage' is not assigned and could be declared final282
Parameter 'voPackage' is not assigned and could be declared final300
Parameter 'businessDelegates' is not assigned and could be declared final318
Avoid excessively long variable names like businessDelegateInfo322
Parameter 'businessDelegateInfo' is not assigned and could be declared final322
Avoid excessively long variable names like commandsWithDelegate340
Parameter 'commandsWithDelegate' is not assigned and could be declared final340
Avoid excessively long variable names like commandWithDelegateTag344
Parameter 'commandWithDelegateTag' is not assigned and could be declared final344
Avoid excessively long variable names like commandsWithoutDelegate362
Parameter 'commandsWithoutDelegate' is not assigned and could be declared final362
Avoid excessively long variable names like commandWithoutDelegateInfo366
Parameter 'commandWithoutDelegateInfo' is not assigned and could be declared final366
Parameter 'events' is not assigned and could be declared final384
Parameter 'eventInfo' is not assigned and could be declared final388
Parameter 'services' is not assigned and could be declared final406
Parameter 'serviceInfo' is not assigned and could be declared final410
Parameter 'value' is not assigned and could be declared final414
Parameter 'imports' is not assigned and could be declared final432

de/aixcept/flex2/annotations/metadata/CommandInfo.java

ViolationLine
Each class should declare at least one constructor11 - 119
Parameter 'name' is not assigned and could be declared final34
Parameter 'packageName' is not assigned and could be declared final52
Parameter 'include' is not assigned and could be declared final62
Parameter 'commandPackage' is not assigned and could be declared final80
Parameter 'eventPackage' is not assigned and could be declared final98
Parameter 'event' is not assigned and could be declared final116

de/aixcept/flex2/annotations/metadata/CommandWithDelegateInfo.java

ViolationLine
Each class should declare at least one constructor29 - 70
Parameter 'delegate' is not assigned and could be declared final49
Parameter 'businessPackage' is not assigned and could be declared final67

de/aixcept/flex2/annotations/metadata/EventInfo.java

ViolationLine
Each class should declare at least one constructor31 - 143
Parameter 'name' is not assigned and could be declared final55
Parameter 'packageName' is not assigned and could be declared final73
Parameter 'constant' is not assigned and could be declared final92
Parameter 'include' is not assigned and could be declared final103
Parameter 'eventPackage' is not assigned and could be declared final122
Parameter 'event' is not assigned and could be declared final140

de/aixcept/flex2/annotations/metadata/PropertyInfo.java

ViolationLine
Each class should declare at least one constructor29 - 70
Parameter 'name' is not assigned and could be declared final49
Parameter 'type' is not assigned and could be declared final67

de/aixcept/flex2/annotations/metadata/ServiceInfo.java

ViolationLine
Each class should declare at least one constructor29 - 108
Avoid variables with short names like id32
Parameter 'type' is not assigned and could be declared final51
Avoid variables with short names like id69
Parameter 'id' is not assigned and could be declared final69
Parameter 'destination' is not assigned and could be declared final87
Parameter 'showBusyCursor' is not assigned and could be declared final105

de/aixcept/util/AnnotationUtils.java

ViolationLine
Each class should declare at least one constructor18 - 222
Parameter 'typeName' is not assigned and could be declared final27
Parameter 'annotations' is not assigned and could be declared final27
Avoid using if statements without curly braces29 - 30
A method should have only one exit point, and that should be the last statement in the method30
Parameter 'annotation' is not assigned and could be declared final46
Local variable could be declared final48
Local variable could be declared final52
Local variable could be declared final53
Local variable could be declared final58
Avoid excessively long variable names like annotationClassName73
Parameter 'annotationClassName' is not assigned and could be declared final73
Parameter 'declaration' is not assigned and could be declared final73
A method should have only one exit point, and that should be the last statement in the method76
Parameter 'type' is not assigned and could be declared final89
Parameter 'declaration' is not assigned and could be declared final89
Local variable could be declared final91
Local variable could be declared final92
Local variable could be declared final100
Local variable could be declared final101
Avoid if (x != y) ..; else ..;102
Parameter 'type' is not assigned and could be declared final111
Parameter 'values' is not assigned and could be declared final111
Local variable could be declared final114
Local variable could be declared final116
Avoid using if statements without curly braces117 - 118
Parameter 'mirror' is not assigned and could be declared final131
Local variable could be declared final133
Local variable could be declared final134
Local variable could be declared final138
Local variable could be declared final146
Avoid instantiating new objects inside loops146
Local variable could be declared final150
Avoid using if...else statements without curly braces153
Avoid using if...else statements without curly braces155
Parameter 'environment' is not assigned and could be declared final176
Parameter 'name' is not assigned and could be declared final176
Avoid using if statements without curly braces181 - 182
A method should have only one exit point, and that should be the last statement in the method182
Local variable could be declared final186
Local variable could be declared final187
Avoid using if statements without curly braces188 - 189
A method should have only one exit point, and that should be the last statement in the method189
Avoid reassigning parameters such as 'comment'202
Avoid reassigning parameters such as 'comment'202
Avoid reassigning parameters such as 'comment'202
Avoid reassigning parameters such as 'comment'202
Avoid reassigning parameters such as 'comment'202
Parameter 'level' is not assigned and could be declared final202
Local variable could be declared final204
Prefer StringBuffer over += for concatenating strings212
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.222

de/aixcept/util/TypeValue.java

ViolationLine
Parameter 'type' is not assigned and could be declared final72
Parameter 'value' is not assigned and could be declared final90
Parameter 'comment' is not assigned and could be declared final108